Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add private_network_ids field for the app model #384

Merged
merged 3 commits into from
Jul 1, 2024
Merged

feat: add private_network_ids field for the app model #384

merged 3 commits into from
Jul 1, 2024

Conversation

SCedricThomas
Copy link
Contributor

@SCedricThomas SCedricThomas commented Jul 1, 2024 •
edited
Loading

@SCedricThomas SCedricThomas self-assigned this Jul 1, 2024
@notion-workspace Notion Workspace
Copy link

Update SDKs

@SCedricThomas SCedricThomas marked this pull request as ready for review July 1, 2024 08:23
@SCedricThomas SCedricThomas requested a review from EtienneM July 1, 2024 08:25
EtienneM
EtienneM approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@EtienneM EtienneM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you remember that there are other SDKs than the Go one?

CHANGELOG.md Outdated Show resolved Hide resolved
@SCedricThomas SCedricThomas mentioned this pull request Jul 1, 2024
Merged
@SCedricThomas @EtienneM
Update CHANGELOG.md
780179b 
Co-authored-by: Étienne M. <EtienneM@users.noreply.github.com>
@SCedricThomas
Copy link
Contributor Author

Yeah ! I checked the ruby one already

@SCedricThomas SCedricThomas merged commit 4d08aee into master Jul 1, 2024
2 checks passed
@SCedricThomas SCedricThomas deleted the feat/STORY-284/private-networks branch July 1, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EtienneM EtienneM EtienneM approved these changes

Assignees

@SCedricThomas SCedricThomas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SCedricThomas @EtienneM